![]() ![]() ![]() You might say that Photoshop itself does this easily. You can easily get rid of the redness of the pupil. Thoughts are welcome.The software also has the ability to retouch portrait or face images. I think it should be fine as long as we keep everything in a dedicated place but I am not an expert. My main concern at this point is about whether touching the DOM from this side could have undesired side effects on the rest of the app. Mounting the component separately could also unblock work to have the widget survive plugin upgrades ( ).Getting full control of when we mount the component can lead to some simplification and avoid potential race conditions during initialization (e.g.Truly global component that doesn't depend on the MM view/route users are in.In practical terms this means we stop relying on registry.registerGlobalComponent and instead directly render the react component in a custom DOM element appended at body level. On top of that the internal component state would be cleared leading to the attached issue (and likely more) and all the calls client listeners would be leaked (registered twice or more).ĭealing with internal component state and reconciliation with the calls client during mounts/unmounts is tricky and can lead to even more problems so in order to simplify I am considering shifting the full lifecycle ownership of the widget component to the plugin side and avoid ever unmounting it while on a call. This has not been a big concern so far as the use case is somewhat limited but still going to admin console while in a call seems like a perfectly acceptable use case and the widget completely disappearing doesn't look good. switching to admin console) or very briefly (joining a new team). Turns out there are a couple of actions in MM that will force the widget component to get unmounted either permanently (e.g.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |